Hello Michael Brown,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3074
to look at the new patch set (#3).
Change subject: IMPALA-3491: Merge test_hbase_metadata.py into
compute_stats.py. Use unique db fixture.
......................................................................
IMPALA-3491: Merge test_hbase_metadata.py into compute_stats.py. Use unique db
fixture.
- Moves the test into compute_stats.py
- Changes some test classes in compute_stats.py to inherit from
ImpalaTestSuite and not from TestComputeStats because that
will cause all tests in TestComputeStats to be run in the
subclasses again (redundantly).
- Clean up and add more coverage to testing incremental stats on
HBase which was probably broken in this commit 6b32ff06.
- Fixes a side effect that the original test had for testing
incremental stats on HBase. It computes stats on a functional
table which was not supposed to have stats.
Testing: Ran compute_stats.py on exhaustive locally in a loop 10 times.
Did a private hdfs/core run.
Change-Id: Iee8b84e30948c3c98166e08cae2666574777730c
---
M
testdata/workloads/functional-query/queries/QueryTest/hbase-compute-stats-incremental.test
M testdata/workloads/functional-query/queries/QueryTest/hbase-compute-stats.test
M tests/metadata/test_compute_stats.py
D tests/metadata/test_hbase_metadata.py
4 files changed, 89 insertions(+), 76 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/74/3074/3
--
To view, visit http://gerrit.cloudera.org:8080/3074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iee8b84e30948c3c98166e08cae2666574777730c
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Alex Behm <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
