Dan, you may want to take a look as well. Dimtris
On Fri, May 20, 2016 at 1:08 PM, Huaisi Xu (Code Review) < [email protected]> wrote: > Huaisi Xu has posted comments on this change. > > Change subject: IMPALA-3494: Fix Thrift TMemoryBuffer overflow > ...................................................................... > > > Patch Set 1: > > ok. i will make to 58. > > I can find a way to write thrift unit test, but we actually never run any > unit test on thirdparty libraries right? so maybe it is not worth it? > > -- > To view, visit http://gerrit.cloudera.org:8080/3149 > To unsubscribe, visit http://gerrit.cloudera.org:8080/settings > > Gerrit-MessageType: comment > Gerrit-Change-Id: I91086ed9d0b4f95b5532de67fe35b46b748ad16c > Gerrit-PatchSet: 1 > Gerrit-Project: Toolchain > Gerrit-Branch: master > Gerrit-Owner: Huaisi Xu <[email protected]> > Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> > Gerrit-Reviewer: Huaisi Xu <[email protected]> > Gerrit-HasComments: No >
