Dan Hecht has posted comments on this change. Change subject: Revert 6bd9c45: IMPALA-3159: Add SAN wildcard SSL support to Thrift Python ......................................................................
Patch Set 3: > I think p4 is there not because it is for subsequent patches. it is > because someone may need p4 version (in bin/impala-config.sh) and > we build this on s3. > > Actually I think we do not need any of them if we only use p7.. > Probably I should include p6 as well? so that is stored in s3? I don't know what you are saying. Are you replying to my suggested comment or something else? My comment is about why we don't need to build p6. It doesn't talk about the p4 build (yes, we still need that one). -- To view, visit http://gerrit.cloudera.org:8080/3173 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f0c57a2dbaa1d8d1157ea9eb490d3d68f39643b Gerrit-PatchSet: 3 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: No
