Michael Ho has posted comments on this change. Change subject: IMPALA-1619: Support 64-bit allocations. ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/2781/2/be/src/runtime/string-buffer.h File be/src/runtime/string-buffer.h: Line 98: if (buffer_ != NULL) pool_->TryFree(reinterpret_cast<uint8_t*>(buffer_), old_size); > I may consider removing this new interface if there is an interface to rese TryFree() has been removed in the latest patch. http://gerrit.cloudera.org:8080/#/c/2781/2/be/src/udf/udf.h File be/src/udf/udf.h: Line 143: /// TODO: 'byte_size' should be 64-bit. > I think these TODOs are potentially confusing and we need ot think carefull It's tracked by IMPALA-2756 now. http://gerrit.cloudera.org:8080/#/c/2781/2/infra/python/bootstrap_virtualenv.py File infra/python/bootstrap_virtualenv.py: Line 114: lib_dir = impala_home + "/toolchain/snappy-1.0.5/lib:" + lib_dir > How about replacing 'impala_home + toolchain' with $IMPALA_TOOLCHAIN ? I am Patch has been updated to use IMPALA_TOOLCHAIN and IMPALA_SNAPPY_VERSION. http://gerrit.cloudera.org:8080/#/c/2781/2/infra/python/deps/download_requirements File infra/python/deps/download_requirements: Line 8: INCLUDE_PATH="$IMPALA_HOME"/toolchain/snappy-1.0.5/include > See my other comment about snappy. Done -- To view, visit http://gerrit.cloudera.org:8080/2781 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ed28083d809a86d801a9c063a0aa32c50d32b20 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
