Jim Apple has posted comments on this change. Change subject: IMPALA-2809: Improve ByteSwap with builtin function or SSE or AVX2. ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/3081/5/be/src/util/bit-util.inline.h File be/src/util/bit-util.inline.h: Line 174: static const FuncPointer SIMDFuncTable[2] = {ByteSwapSSE_Unit, ByteSwapAVX2_Unit}; > Done I am suggesting that this template function declaration start with template<int TEMPLATE_DATA_WIDTH, FuncPointer SIMDFunc>... Line 185: if(i >= 16) { > The formatting of if () { and while () { is missing spaces. in many places. You might try clang-format. Here is my .clang-format config: BasedOnStyle: Google AlignAfterOpenBracket: 'false' AlignOperands: 'false' AllowShortFunctionsOnASingleLine: 'true' AllowShortIfStatementsOnASingleLine: true ColumnLimit: '90' ConstructorInitializerIndentWidth: '2' ContinuationIndentWidth: '4' #Cpp11BracedListStyle: true #AlignEscapedNewlinesLeft: true PenaltyBreakBeforeFirstCallParameter: '99999999' Standard: Cpp03 -- To view, visit http://gerrit.cloudera.org:8080/3081 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I392ed5a8d5683f30f161282c228c1aedd7b648c1 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Youwei Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Youwei Wang <[email protected]> Gerrit-HasComments: Yes
