Huaisi Xu has posted comments on this change. Change subject: IMPALA-3282: TBinaryProtocol buffers consume unbounded memory ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3201/3/source/thrift/thrift-0.9.0-patches/0008-IMPALA-3582-string-buffer-memory.patch File source/thrift/thrift-0.9.0-patches/0008-IMPALA-3582-string-buffer-memory.patch: Line 38: - uint8_t* string_buf_; according to your change. this looks completely useless.. will the resize "churn allocating memory on every string read"? May I ask how large is this buffer when you think it is problematic? -- To view, visit http://gerrit.cloudera.org:8080/3201 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58bdc899e604bde2f5b2d5360f79537ce25715ee Gerrit-PatchSet: 3 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: Yes
