Lars Volker has posted comments on this change. Change subject: IMPALA-3581: Change location of minidump folders to log_dir ......................................................................
Patch Set 5: (3 comments) Thank you for the review. Please see PS6. http://gerrit.cloudera.org:8080/#/c/3171/5/bin/collect_minidumps.py File bin/collect_minidumps.py: Line 169: \ > I think it would be nicer without this character, like this: Done Line 174: minidump_path > I think you should rename this to result, like this: Done Line 176: sys.exit(1) > Should we print a message to stderr here? something like "minidump director Done -- To view, visit http://gerrit.cloudera.org:8080/3171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idecf5a314bfb8b0870e8aa4819c4fb39a107702f Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
