Taras Bobrovytsky has posted comments on this change.

Change subject: IMPALA-3335: enable single-node optimizaion with joins
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3161/2/testdata/workloads/functional-planner/queries/PlannerTest/small-query-opt.test
File 
testdata/workloads/functional-planner/queries/PlannerTest/small-query-opt.test:

Line 11: # Query is over the limit of 8 rows to be optimized, will distribute 
the query
> test is expected to produce a distributed plan
Done


Line 160:   functional.alltypestiny a join functional.alltypestiny b on a.id = 
b.id;
> nit: remove trailing ":" since it's not necessary
Done


Line 192: select * from
> add comment why the optimization does nit kick in here
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7de9b759f444bbf3c6505e8dd0b0c7c58dbd1596
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Taras Bobrovytsky <[email protected]>
Gerrit-HasComments: Yes

Reply via email to