Michael Ho has posted comments on this change. Change subject: IMPALA-3608: Updates Impala E2E test framework to allow multiple exception messages ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3205/1/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: Line 197: actual_str = actual_str.replace('\n', '') > Good point. Chose the latter one. Actually, this doesn't work as this only strips newline at the beginning and the end of the string but it doesn't handle newline character in the middle. So, I restored to the previous version of using replace(). -- To view, visit http://gerrit.cloudera.org:8080/3205 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6d81fd3ae601f565b575edfeefff7c5a6c07974 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
