Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3369: Add ALTER TABLE SET COLUMN STATS statement. ......................................................................
Patch Set 5: (1 comment) Thanks for making the changes Alex, the Enum change in ColumnStats looks pretty clean. I have no other comments. LGTM. http://gerrit.cloudera.org:8080/#/c/3189/5/testdata/workloads/functional-query/queries/QueryTest/alter-table-set-column-stats.test File testdata/workloads/functional-query/queries/QueryTest/alter-table-set-column-stats.test: Line 109: ---- RESULTS : ---- TYPES nit: I think these are not mandatory sections, we can omit if we are not doing any result verification. (here and elsewhere in this file) -- To view, visit http://gerrit.cloudera.org:8080/3189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45cd8aa7241ea962788ba9ca7d0bbfd864c4304f Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: Yes
