Casey Ching has posted comments on this change. Change subject: download_requirements should download kudu-python and virtualenv ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3217/1/infra/python/deps/download_requirements File infra/python/deps/download_requirements: Line 17: "$PIP" install --download "$DIR" --no-use-wheel \ Why not use wheels? I think they should be probably preferred since the installation would be faster. Line 28: echo "kudu-python install failed. This is expected if we do not yet have an installed"\ I guess you mean "kudu-python download failed"? Does that really depend on having the Kudu client installed? -- To view, visit http://gerrit.cloudera.org:8080/3217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9216596db0f37d706ea7f77c129cecd5b070429 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
