Dan Hecht has posted comments on this change. Change subject: IMPALA-3577, IMPALA-3486: Partitions on multiple filesystems breaks with S3_SKIP_INSERT_STAGING ......................................................................
Patch Set 12: Code-Review+2 (2 comments) Thanks, that looks good. Which jobs will you add the new SECONDARY_FILESYSTEM parameter to? http://gerrit.cloudera.org:8080/#/c/3146/12/tests/query_test/test_multiple_filesystems.py File tests/query_test/test_multiple_filesystems.py: Line 12: # This should currently run only with HDFS as the defaultFS. Is HDFS the defaultFS actually required, or is it just that SECONARY_FILESYSTEM needs to be specified? Assuming the latter, please update this comment. Line 55: self._multiple_filesystems_helper(vector, unique_database) do we still need _multiple_filesystem_helper? -- To view, visit http://gerrit.cloudera.org:8080/3146 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib13b610eb9efb68c83894786cea862d7eae43aa7 Gerrit-PatchSet: 12 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
