Michael Ho has posted comments on this change. Change subject: IMPALA-3066: Lazy materialization of LLVM module bitcode. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3220/1/be/src/codegen/llvm-codegen.h File be/src/codegen/llvm-codegen.h: Line 414: /// Loads an LLVM module. 'module_ir' should be a reference to a memory buffer containing : /// LLVM bitcode. module_name is the name of the module to use when reporting errors. : /// The caller is responsible for cleaning up module. : static Status LoadModuleFromMemory(LlvmCodeGen* codegen, : llvm::MemoryBufferRef module_ir, std::string module_name, : std::unique_ptr<llvm::Module>* modu Bad rebase. Will remove it in the next patch. -- To view, visit http://gerrit.cloudera.org:8080/3220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ed7862fc5e86005ecea83fa2ceb489e737d66b2 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
