Tim Armstrong has posted comments on this change. Change subject: IMPALA-3619: disable IR symbols by default ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3223/1/bin/impala-config.sh File bin/impala-config.sh: Line 56: # If enabled, debug symbols are added to cross-compiled IR. > What cases would a developer want to do this? Also, is it ever useful to h It would be necessary for any meaningful debugging of cross-compiled IR. GDB/LLVM have some integration but I haven't tested it out. The symbols also show up in the ASM dumps, so you can trace back assembly to source lines. Unfortunately the line-level symbols get lost in some of the IR manipulation so it's not as useful as it could be. It might be useful to ship debug IR to get better symbols for debug codegen crashes, but that's probably a pretty niche use case. -- To view, visit http://gerrit.cloudera.org:8080/3223 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5426fe3f8be0b7a100c0c3683c8ef1eaf507146 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
