Jim Apple has posted comments on this change. Change subject: IMPALA-3604: Clean up SSE handling ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3227/1/be/src/util/sse-util.h File be/src/util/sse-util.h: Line 85: /// CPU requirement is raised to at least the targeted instruction set. Please do not create empty #if blocks. Line 97: static inline __m128i SSE4_cmpestrm(__m128i str1, int len1, __m128i str2, int len2) { Why did you remove the comment that was here? Line 99: __asm__ volatile ("pcmpestrm %5, %2, %1" Can clang use the intrinsics? -- To view, visit http://gerrit.cloudera.org:8080/3227 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id346187f3248922ec2a323548de4bdeaccd7a771 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Youwei Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
