Tim Armstrong has posted comments on this change. Change subject: IMPALA-3639: expr-test fails on ASAN ......................................................................
Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/3241/1/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 230: const string It's returning a copy so the const is unnecessary. Line 896: return value.compare("false"); Maybe add a DCHECK that the value is "true" otherwise? -- To view, visit http://gerrit.cloudera.org:8080/3241 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I040179ee44782a22c88b810ff97612aaa89839f4 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
