Tim Armstrong has posted comments on this change. Change subject: IMPALA-3632: Add script for runnig cppclean over the BE code. ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3237/1/CMakeLists.txt File CMakeLists.txt: Line 361: if (DUMP_INCLUDE_PATHS) It would make more sense for this to be a custom target. http://gerrit.cloudera.org:8080/#/c/3237/1/bin/cppclean.sh File bin/cppclean.sh: Line 2: # Copyright header? Line 30: eval $CMD eval isn't necessary here, could just do something like cppclean --include-path=$IMPALA_HOME/be/src/ .. ${INCLUDE_PATHS} $@ $IMPALA_HOME/be -- To view, visit http://gerrit.cloudera.org:8080/3237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5cd064344bdf47d77058fb570f034bb324308103 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
