Michael Ho has posted comments on this change. Change subject: IMPALA-3181: Add noexcept to some functions ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3256/1//COMMIT_MSG Commit Message: Line 10: known to not throw exceptions A more precise statement would be "known to not throw exceptions explicitly". In theory, new operator can throw exception but even if it does, we don't know how to handle it in the current code anyway. -- To view, visit http://gerrit.cloudera.org:8080/3256 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I96bd2fec6c14771acae1e700bed958951368ee77 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
