Henry Robinson has posted comments on this change. Change subject: Impala-3521: Before Impala Network monitor ports start, should not Communication with statetore ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/3264/1//COMMIT_MSG Commit Message: Line 7: mpala-352 please capitalise: IMPALA-3521: ... Line 7: Before Impala Network monitor ports start, should not Communication : with statetore Please make the title a) more succinct and b) clearer. You don't have to copy the title from the JIRA. Line 13: in which we perform these operations. You should say why this needs changing, not just that you did it. http://gerrit.cloudera.org:8080/#/c/3264/1/be/src/service/impalad-main.cc File be/src/service/impalad-main.cc: Line 80: // this blocks until the beeswax and hs2 servers terminate Comment should be probably on line 92. -- To view, visit http://gerrit.cloudera.org:8080/3264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c09dafa5475978424e63bc936c0cdf4940df8d7 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: anujphadke <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-HasComments: Yes
