Huaisi Xu has posted comments on this change. Change subject: IMPALA-3499: Batch update catalog cache update. ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3067/5/be/src/service/impala-server.h File be/src/service/impala-server.h: Line 744: ut is necessary to split update in CatalogUpdateCallback. > explain what this is protecting against - simultaneous updates? I added this only to preserve the same consistency guarantee. Since there are two places will call UpdateCatalogCache(). In the frontend code, it looks like it does not want UpdateCatalogCache() to be called simultaneously. During split update, it is possible that other thread calls UpdateCatalogCache() in the middle of a split update. I am not sure exactly why but I just want to preserve the same consistency guarantee. what do you think? -- To view, visit http://gerrit.cloudera.org:8080/3067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I176db25124a32944f2396ce8aafbed49cac95928 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
