Dan Hecht has posted comments on this change. Change subject: IMPALA-1346/1590: fix sorter buffer mgmt when spilling ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/2908/5/be/src/runtime/sorter.cc File be/src/runtime/sorter.cc: Line 1449: void Sorter::Close() { maybe we can add a DCHECK that basically verifies that if the sorter completed successfully, then blocks have already been cleared (to verify we give back memory asap)? maybe it's not easy to verify that currently, and if not, okay. -- To view, visit http://gerrit.cloudera.org:8080/2908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfe55cc13c7f2b54cba1d05ade44cbcf6bb573c0 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
