Jim Apple has posted comments on this change. Change subject: IMPALA-3491: Use unique_database fixture in test_metadata_query_statements.py. ......................................................................
Patch Set 1: (1 comment) Other than that, I am convinced I traced where all of the various test commands moved from and to in the various files. For your future reviewers on future patches, it might help to add some comments in gerrit about what went where and why. http://gerrit.cloudera.org:8080/#/c/3103/1/tests/metadata/test_metadata_query_statements.py File tests/metadata/test_metadata_query_statements.py: Line 169 Did you drop this because self.cleanup_db already does it, or because it's not necessary, or some other reason? -- To view, visit http://gerrit.cloudera.org:8080/3103 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0af1dc6534234508bd0fed03531f7fe8ff556aa Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-HasComments: Yes
