Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3639: expr-test fails on ASAN ......................................................................
IMPALA-3639: expr-test fails on ASAN In ExprTest::GetValue, we create a local string and then end up returning a reference to that string, resulting in a memory error. The mistake wasn't obvious from looking at the code due to the convoluted way that GetValue and ConvertValue work. This patch modifies GetValue and ConvertValue to be simpler and eliminates the memory error. Change-Id: I040179ee44782a22c88b810ff97612aaa89839f4 Reviewed-on: http://gerrit.cloudera.org:8080/3278 Reviewed-by: Thomas Tauber-Marshall <[email protected]> Tested-by: Internal Jenkins --- M be/src/exprs/expr-test.cc 1 file changed, 125 insertions(+), 141 deletions(-) Approvals: Internal Jenkins: Verified Thomas Tauber-Marshall: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/3278 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I040179ee44782a22c88b810ff97612aaa89839f4 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
