Tim Armstrong has posted comments on this change. Change subject: IMPALA-1346/1590/2344: fix sorter buffer mgmt when spilling ......................................................................
Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/2908/6/be/src/runtime/sorter.cc File be/src/runtime/sorter.cc: Line 770: *pinned_all_blocks = false; > should we unpin fixed_len_blocks_[0] at this point? I decided against doing that, since that may mean writing it back to disk, and we're going to pin it again for the next merge anyway. PS6, Line 1500: remaining > delete, or reword some other way. Comment was deleted as part of fix for next comment. PS6, Line 1504: if (sorted_runs_.size() >= min_runs_for_intermediate_merge) { > Not sure this is worth the complication before we have reservations. See c Done PS6, Line 1527: three > four... This comment went away with the above simplification. -- To view, visit http://gerrit.cloudera.org:8080/2908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfe55cc13c7f2b54cba1d05ade44cbcf6bb573c0 Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
