Michael Brown has posted comments on this change. Change subject: IMPALA-3614: work around pytest bugs causing custom cluster test skips ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/3265/1/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: PS1, Line 58: explicit > Explicit ? Done PS1, Line 60: # IMPALA-3614: @SkipIfLocal.multiple_impalad workaroun > Can you please add a TODO statement to remove the workaround once pytest ha Done PS1, Line 66: explicit > Explicit ? Done PS1, Line 67: basic > basis ? Done http://gerrit.cloudera.org:8080/#/c/3265/1/tests/custom_cluster/test_spilling.py File tests/custom_cluster/test_spilling.py: PS1, Line 33: # Start with 256KB buffers, to reduce data size required to force spilling. : cls._start_impala_cluster(['--impalad_args=--"read_size=262144"', : 'catalogd_args="--load_catalog_in_background=false"']) > Can this be replaced by the with_args() decorator too or does it have to ha Not exactly, but I cleaned things up a little bit, including adding slightly clearer comments. -- To view, visit http://gerrit.cloudera.org:8080/3265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie301b69718f8690322cc3b4130fb1c715344779c Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Michael Brown <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
