Alex Behm has posted comments on this change.

Change subject: IMPALA-3491: Use unique_database fixture in 
test_metadata_query_statements.py.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3103/1/tests/metadata/test_metadata_query_statements.py
File tests/metadata/test_metadata_query_statements.py:

Line 169
> Did you drop this because self.cleanup_db already does it, or because it's 
As far as I could tell, this part is only meant for cleaning up before the 
test, so it doesn't matter whether Hive or Impala do it. Having Impala do it 
makes things easier (no need for invalidate metadata). So yes, cleanup_db() 
does it.


-- 
To view, visit http://gerrit.cloudera.org:8080/3103
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0af1dc6534234508bd0fed03531f7fe8ff556aa
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Alex Behm <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Jim Apple <[email protected]>
Gerrit-HasComments: Yes

Reply via email to