Tim Armstrong has posted comments on this change. Change subject: IMPALA-3646: Handle corrupt RLE literal or repeat counts of 0. ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3299/1/be/src/util/rle-test.cc File be/src/util/rle-test.cc: Line 284: TEST(Rle, BitWidthZeroRepeated) { It's good that we have some coverage of this. http://gerrit.cloudera.org:8080/#/c/3299/1/testdata/workloads/functional-query/queries/QueryTest/parquet-corrupt-rle-counts.test File testdata/workloads/functional-query/queries/QueryTest/parquet-corrupt-rle-counts.test: PS1, Line 8: hdfs Does this work on all FS's? http://gerrit.cloudera.org:8080/#/c/3299/1/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: PS1, Line 234: \ Continuation isn't needed, since it's in parenthesees. -- To view, visit http://gerrit.cloudera.org:8080/3299 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf406c82cdded37966f09c81e4cc1446d2b60d63 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
