Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-3441: check for malformed Avro data ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3072/5/be/src/exec/hdfs-avro-scanner.cc File be/src/exec/hdfs-avro-scanner.cc: Line 666: // br i1 %success, label %end_field, label %bail_out > It may be worth adding branch-weight metadata to these branches (the equiva I just tried this, still no measurable effect. For this benchmark at least, it looks like the increase in time is dominated by the extra work in ReadZLong() (I just tried commenting out various lines to verify this). -- To view, visit http://gerrit.cloudera.org:8080/3072 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I801a11c496a128e02c564c2a9c44baa5a97be132 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
