Michael Brown has posted comments on this change.

Change subject: preview IMPALA-3630: forward end-to-end test arguments to 
custom cluster tests
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3307/4/bin/run-all-tests.sh
File bin/run-all-tests.sh:

PS4, Line 89: exploration_strategy
> My assumption was, that this needs to be set to exhaustive for the breakpad
Our workload / exploration strategy situation is a bit of a mess. The only 
workload that ever gets run in Jenkins is functional-query. When we say our 
Jenkins jobs run "exhaustive", what that really means is "exhaustive 
functional-query". If you look at L158-159 in the base you'll see this. The 
breakpad tests aren't running because they're part of the functional-query 
workload, but we don't pass the --workload_exploration_strategy 
functional-query:$EXPLORATION_STRATEGY (or any other) arguments to 
run-custom-cluster.sh. I simply moved some code around and made sure the 
py.test arguments get passed to all py.test runners.

Ironing out the workload situation, and the separate custom-cluster-tests.sh 
script, seemed out of scope for 2.6.0, but this little move seemed reasonable 
for 2.6.0.

If it would help, let me know if I should move some of this explanation into 
the commit message.


-- 
To view, visit http://gerrit.cloudera.org:8080/3307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57f9ab6235f99e6a4d5fb50b87ceba3584b6b6d2
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Michael Brown <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
Gerrit-HasComments: Yes

Reply via email to