David Knupp has posted comments on this change. Change subject: IMPALA-3491: Use unique_database fixture in test_last_ddl_time_update.py. ......................................................................
Patch Set 2: Code-Review+2 I think this is fine. Though I think it's probably more "correct" to break tests out individually (despite being more verbose, as you've noted), this accomplishes the original intent of enabling greater concurrency of test execution. There may well be some general test refactoring that needs to happen soon anyway. (Our python code is not PEP 8 compliant, and perhaps should be before the ASF repo becomes official?) We can revisit the other points then. -- To view, visit http://gerrit.cloudera.org:8080/3104 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97e96217301078d48584c51218345dc96f6853a6 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-HasComments: No
