Dan Hecht has posted comments on this change. Change subject: IMPALA-3680: Reset the file read offset for failed hdfs cache reads ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3313/1/be/src/runtime/disk-io-mgr-scan-range.cc File be/src/runtime/disk-io-mgr-scan-range.cc: Line 432: hdfsSeek(fs_, hdfs_file_->file(), 0); how did this work before, and how does this work? Shouldn't we seek to file offset 'offset_'? Actually, why is this needed since won't we call ScanRange::Open() before doing the normal file read anyway? -- To view, visit http://gerrit.cloudera.org:8080/3313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a9ea19dd8571b01d2cd5b87da1c259219f6297a Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-HasComments: Yes
