Tim Armstrong has submitted this change and it was merged.

Change subject: IMPALA-3669: test_scratch_disk fails on S3
......................................................................


IMPALA-3669: test_scratch_disk fails on S3

Make the test deterministic by using max_block_mgr_memory instead of
mem_limit, so that the non-deterministic scanner memory usage does not
influence the spilling behaviour of the queries.

Testing:
Ran the test locally to confirm that it succeeded. Also manually
computed the memory requirement. The data size to be sorted is ~220MB,
so with a 64MB block manager limit per node, at least one node must
spill.

Change-Id: I9525a029ac020bb5b8bea210a741c9f9c5ec3c75
Reviewed-on: http://gerrit.cloudera.org:8080/3318
Reviewed-by: Dan Hecht <[email protected]>
Reviewed-by: Michael Brown <[email protected]>
Reviewed-by: Silvius Rus <[email protected]>
Tested-by: Tim Armstrong <[email protected]>
---
M tests/custom_cluster/test_scratch_disk.py
1 file changed, 8 insertions(+), 7 deletions(-)

Approvals:
  Michael Brown: Looks good to me, but someone else must approve
  Silvius Rus: Looks good to me, approved
  Tim Armstrong: Verified
  Dan Hecht: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/3318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9525a029ac020bb5b8bea210a741c9f9c5ec3c75
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
Gerrit-Reviewer: Silvius Rus <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>

Reply via email to