Huaisi Xu has posted comments on this change.

Change subject: IMPALA-3499: Split catalog update
......................................................................


Patch Set 13:

> - Regarding testing, did you try testing this on a cluster with
 > large topics? Not sure, if our test suite topics are big enough to
 > hit the conditions added in this patch.
 > 
 > - I think we can use HMS dumps from any of our SFDC cases incase
 > you need large topics.

I test that with 10k batch size limit with full dataloading. I saw tons of 
split. No need to test 500m limit I think... (the test branch has different 
setting than this patch)

-- 
To view, visit http://gerrit.cloudera.org:8080/3067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I176db25124a32944f2396ce8aafbed49cac95928
Gerrit-PatchSet: 13
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Huaisi Xu <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Huaisi Xu <[email protected]>
Gerrit-HasComments: No

Reply via email to