Huaisi Xu has posted comments on this change. Change subject: IMPALA-3613: Do not update unregistered subscribers ......................................................................
Patch Set 2: > Hm - isn't that unexpected if the queue size doesn't increase over > time? Shouldn't the subscribers continually append to the heartbeat > queue? I checked and I think that is because the recoverymodechecker has a 5s checking circle, which I did not change, so statestore is able to clean everything. The point of this patch is to avoid resending update/heartbeat to re-registered node. Does this explain you question? -- To view, visit http://gerrit.cloudera.org:8080/3320 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic573d257b8171bfcab33a1f72de1399be7db10fd Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: No
