Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-3441, IMPALA-3659: check for malformed Avro data ......................................................................
Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/3072/13/be/src/exec/hdfs-avro-scanner.cc File be/src/exec/hdfs-avro-scanner.cc: PS13, Line 485: data_len > data_len is uninitialized in the uncompressed case. Done Line 533: this, max_tuples, pool, &data, data + data_len, tuple, tuple_row); > Why wasn't this caught by testing? What should we do to exercise that bug? I didn't add a test file that's long enough to trigger multiple iterations of this loop (I could also adjust the batch size). -- To view, visit http://gerrit.cloudera.org:8080/3072 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I801a11c496a128e02c564c2a9c44baa5a97be132 Gerrit-PatchSet: 13 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
