Huaisi Xu has posted comments on this change. Change subject: IMPALA-3499: Split catalog update ......................................................................
Patch Set 16: (4 comments) http://gerrit.cloudera.org:8080/#/c/3067/16/be/src/service/frontend.h File be/src/service/frontend.h: PS16, Line 38: of > "of" twice. Done http://gerrit.cloudera.org:8080/#/c/3067/16/be/src/service/impala-server.cc File be/src/service/impala-server.cc: Line 1263: incremental_request->__set_catalog_service_id( > For supportability purposes, could you log something about the catalog_obje Done Line 1278: if (current_topic_update_size_bytes + len > MAX_CATALOG_UPDATE_BATCH_SIZE_BYTES) { > I still think its cleaner to move this block after L1254. (even though the The memory for that catalog object was already allocated. (that exists even when we send empty update)... c++ works different than java. correct me if I am wrong.. Henry PS16, Line 1279: TUpdateCatalogCacheRequest > Based on my understanding of Java thrift libraries, calling the default con I think that is because c++ class works different than Java class. the behavior you said probably is in java, and does not apply to c++.. I got confused as well previously. -- To view, visit http://gerrit.cloudera.org:8080/3067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I176db25124a32944f2396ce8aafbed49cac95928 Gerrit-PatchSet: 16 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: Yes
