Matthew Jacobs has posted comments on this change. Change subject: Move Impala HTTP handlers to a separate class ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3370/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: PS1, Line 316: http_handler_.reset(new ImpalaHttpHandler(this)); It doesn't look like ImpalaHttpHandler holds onto any state that needs to be alive after RegisterHandlers() returns. Can we avoid making this a member and just create it on the stack here? -- To view, visit http://gerrit.cloudera.org:8080/3370 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8453b3367653914163ca6acae48e7605f73cc675 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
