Dan Hecht has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filters by 10-100%. ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/3338/5/be/src/util/bloom-filter.h File be/src/util/bloom-filter.h: Line 187: if (CpuInfo::IsSupported(CpuInfo::AVX2)) { > Since this affects the data layout rather than switching between two equiva If the datalayout is impacted, then I agree having a member makes sense. This also needs to be called out clearly in comments (currently, it's kind of implicit in the comments). PS5, Line 188: BucketInsertAVX2 can you double check that we aren't double dispatching? I.e. is this a direct call or do we get a call to a "jmp *addr" here due to the target attribute? (The compiler wouldn't know we've already done the dispatch ourselves and I'm not sure it takes into account whether there is a single implementation). -- To view, visit http://gerrit.cloudera.org:8080/3338 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fef4f6652876f8fd7e3f0e41431702380418c98 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
