Huaisi Xu has posted comments on this change. Change subject: IMPALA-3711: Only check privilege for databases in getSchemas() ......................................................................
Patch Set 1: > I don't think these changes are correct. I believe the HS2 API > specifies that getSchemas(), getTables(), etc, should be able to > accept a search pattern as an input parameter. You seem to remove > that functionality altogether, but this is not what we want. Could you elaborate? Our currently API for getSchamas() is: getSchemas(Frontend fe, String catalogName, String schemaName, User user) It does not take table name or column name at all as input parameter. My patch only changes the inner behavior of getSchemas(), which I believe is invisible.? right? -- To view, visit http://gerrit.cloudera.org:8080/3371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17d8c5b9fb12483e4b01b819fba48b6849311a14 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: No
