Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3491: Use unique_database fixture in test_catalog_service_client.py. ......................................................................
IMPALA-3491: Use unique_database fixture in test_catalog_service_client.py. Even though this is just a single test, this change introduces the unique_database test fixture that was initially created to help with concurrent tests. It's still worth to do this here because we want to update all tests to use best practices. That said, there was still a performance gain to be had here. It turns out the initial code called the cleanup_db() method from the base ImpalaTestSuite class, which in turn sets the 'sync_ddl' query option to true. Not doing this at the beginning of this test results in a roughly 40x speedup. Change-Id: I5d6994f31d52e18e2e04aab0e34202e2c623e367 Reviewed-on: http://gerrit.cloudera.org:8080/3366 Reviewed-by: David Knupp <[email protected]> Tested-by: Internal Jenkins --- M tests/catalog_service/test_catalog_service_client.py 1 file changed, 11 insertions(+), 19 deletions(-) Approvals: David Knupp: Looks good to me, approved Internal Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3366 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d6994f31d52e18e2e04aab0e34202e2c623e367 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Internal Jenkins
