Henry Robinson has posted comments on this change.

Change subject: IMPALA-3735: Add per-fragment information to debug webpage
......................................................................


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/3323/2/be/src/service/fragment-mgr.cc
File be/src/service/fragment-mgr.cc:

PS2, Line 52: ember("id"
> nit: PrintId(v.first).c_str() ?
Done


http://gerrit.cloudera.org:8080/#/c/3323/2/www/fragments.tmpl
File www/fragments.tmpl:

PS2, Line 2: 2016
> 2016
Done


PS2, Line 30: 
> Is it better to make to link it to {{coordinator}}:25000/query_fragments?qu
Added a link to the query, rather than to the fragment directly.


http://gerrit.cloudera.org:8080/#/c/3323/2/www/query_fragments.tmpl
File www/query_fragments.tmpl:

PS2, Line 2:  2016
> 2016
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d995da50c3a119b7aaf04d6f87e60e9e573a5ed
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Henry Robinson <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-HasComments: Yes

Reply via email to