Henry Robinson has posted comments on this change.

Change subject: IMPALA-3499: Split catalog update
......................................................................


Patch Set 20:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3067/20/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

PS20, Line 1262: if (len > 100 * 1024 * 1024 /* 100MB */) {
               :         LOG(WARNING) << "Received large catalog 
update(>100mb): "
               :                      << item.key << " is "
               :                      << PrettyPrinter::Print(len, 
TUnit::BYTES);
               :       }
> Sorry missed this, my intention here was to add some debug logging to figur
Makes sense. This shouldn't be logged at WARNING level, though. At most it 
should be INFO as long as it doesn't happen very often.


-- 
To view, visit http://gerrit.cloudera.org:8080/3067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I176db25124a32944f2396ce8aafbed49cac95928
Gerrit-PatchSet: 20
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Huaisi Xu <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Huaisi Xu <[email protected]>
Gerrit-HasComments: Yes

Reply via email to