Dan Hecht has posted comments on this change. Change subject: IMPALA-3732: handle string length overflow in avro files ......................................................................
Patch Set 1: Code-Review+2 (4 comments) http://gerrit.cloudera.org:8080/#/c/3383/1//COMMIT_MSG Commit Message: PS1, Line 13: is nit: can be http://gerrit.cloudera.org:8080/#/c/3383/1/be/src/exec/hdfs-avro-scanner-ir.cc File be/src/exec/hdfs-avro-scanner-ir.cc: PS1, Line 188: /// nit: these should be double slash PS1, Line 206: /// same http://gerrit.cloudera.org:8080/#/c/3383/1/be/src/exec/hdfs-avro-scanner-test.cc File be/src/exec/hdfs-avro-scanner-test.cc: Line 330: /// Test handling of strings that would overflow the StringValue::len 32-bit integer. maybe test both cases where bit 31 is 0 and 1 (i.e. truncated result is positive and negative)? -- To view, visit http://gerrit.cloudera.org:8080/3383 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6541e7c68255bf599b26386a55057c93e62af51 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-HasComments: Yes
