Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2836: Change permissions for ADD/DROP PARTITION ......................................................................
Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/3327/4//COMMIT_MSG Commit Message: PS4, Line 15: ALTER(Ownership) Why is that the case? Shouldn't it be INSERT on table and ALL permission on the URI? Isn't that what Hive does? http://gerrit.cloudera.org:8080/#/c/3327/4/fe/src/main/java/com/cloudera/impala/analysis/AlterTableStmt.java File fe/src/main/java/com/cloudera/impala/analysis/AlterTableStmt.java: Line 74: * caller to specify privilege required for executing the alter statement "the table" Line 75: * remove extra space PS4, Line 76: @param analyzer : * @param privilege : * the privilege required for the statement : * @throws AnalysisException We don't use java doc (for the most part). Can you plz remove this? -- To view, visit http://gerrit.cloudera.org:8080/3327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d971f0ab46fed87b0428d344d002a42644b9847 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: Yes
