David Knupp has posted comments on this change. Change subject: xfail s3a_keys_do_not_work custom cluster test ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3379/2/tests/custom_cluster/test_s3a_access.py File tests/custom_cluster/test_s3a_access.py: Line 68: pytest.xfail("IMPALA-3664: Feature unsupported in this branch") > We do not want to run this test test in the release branch because the feat Thanks Sailesh for the explanation. I guess I was just wondering, would it work to move the xfail() call to just before the last line of the method here? Because from looking at the JIRA, it appears like the the CREATE query succeeds -- it's just the SELECT query that fails. (In my mind, those are really seem to be two separate tests, since they undoubtedly exercise two vary different code paths.) In other words, would it be worthwhile to continue confirming that the CREATE query continues to perform as expected, even when bad S3 credentials are supplied? Or do you want to bypass both tests? -- To view, visit http://gerrit.cloudera.org:8080/3379 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f9948fafd2f5d2363e88a60e67cf751f2fa5f93 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
