Dan Hecht has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filters by 10-100%. ......................................................................
Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/3338/7/be/src/util/bloom-filter.h File be/src/util/bloom-filter.h: Line 176: if (CpuInfo::IsSupported(CpuInfo::AVX2)) { > It will save a couple of instructions and ideally the boolean will be read There should be no cost difference. IsSupported is just a bit-test which is a single instruction (TESTL). And making it a const bool in the class won't allow it to be in a register. In the medium term we can get rid of these using code-gen anyway. -- To view, visit http://gerrit.cloudera.org:8080/3338 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fef4f6652876f8fd7e3f0e41431702380418c98 Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
