Jim Apple has posted comments on this change. Change subject: IMPALA-2809: Improve ByteSwap with builtin function or SSE or AVX2. ......................................................................
Patch Set 17: (2 comments) http://gerrit.cloudera.org:8080/#/c/3081/17/be/src/util/bit-util.inline.h File be/src/util/bit-util.inline.h: Line 25: inline void ByteSwapScalarLoop(void* dst, const void* src, int len) { > Good suggestion. DONE. Where? A number of the "Done" comments are not done yet, from what I can see. Did you forget to uplaod? Line 136: #ifndef IR_COMPILE > Hi Jim. Would you please tell which clang version you are using to build th 3.8: https://github.com/cloudera/native-toolchain/tree/master/source/llvm -- To view, visit http://gerrit.cloudera.org:8080/3081 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I392ed5a8d5683f30f161282c228c1aedd7b648c1 Gerrit-PatchSet: 17 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Youwei Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Youwei Wang <[email protected]> Gerrit-HasComments: Yes
