Tim Armstrong has posted comments on this change. Change subject: IMPALA-3751: fix clang build errors and warnings ......................................................................
Patch Set 2: Code-Review+2 (1 comment) GCC warned over the rewrite. Apparently constructing 128-bit integers across compilers isn't that portable. Went with a different approach. http://gerrit.cloudera.org:8080/#/c/3391/1/be/src/exec/zigzag-test.cc File be/src/exec/zigzag-test.cc: PS1, Line 110: ok > how did this not get caught in GVM? ZLongResult::error is a valid function pointer, which evaluates to 'true' when implicitly cast to a bool. -- To view, visit http://gerrit.cloudera.org:8080/3391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie71a483789d3be06248036ab3bbee82d66580973 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
