Amos Bird has posted comments on this change. Change subject: IMPALA-1654: Support general predicates in most partition DDL operations. ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/1563/4//COMMIT_MSG Commit Message: Line 16: Change-Id: I2c9162fcf9d227b8daf4c2e761d57bab4e26408f > This language about "partitionSpec" is hard to follow without the code in f Done PS4, Line 19: > Can you please explain here what "fully bounded" means? Oh, I was using the comment from Expr.java. Fully bounded means the expression contains one and only one slotref that refers to the given column. http://gerrit.cloudera.org:8080/#/c/1563/4/fe/src/main/java/com/cloudera/impala/planner/HdfsPartitionPruner.java File fe/src/main/java/com/cloudera/impala/planner/HdfsPartitionPruner.java: PS4, Line 91: > Did you mean "no file"? Also, by "may be added", do you mean added as in AD Done -- To view, visit http://gerrit.cloudera.org:8080/1563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c9162fcf9d227b8daf4c2e761d57bab4e26408f Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Amos Bird <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Amos Bird <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-HasComments: Yes
