Jim Apple has posted comments on this change. Change subject: IMPALA-3622: Unacceptable '\0' used as fields terminator when creating tables ......................................................................
Patch Set 1: (4 comments) This needs much more explanation and some tests. http://gerrit.cloudera.org:8080/#/c/3266/1//COMMIT_MSG Commit Message: Line 7: IMPALA-3622: Unacceptable '\0' used as fields terminator when creating tables long lines. Line 11: rule, so the bug occurs. This doesn't really explain - can you summarize the bug that occurs, please? Line 14: the delimiter is '\0' or '\u0000' for the time being. until when? http://gerrit.cloudera.org:8080/#/c/3266/1/fe/src/main/java/com/cloudera/impala/catalog/RowFormat.java File fe/src/main/java/com/cloudera/impala/catalog/RowFormat.java: Line 60: if (fieldDelimiter_ != null && fieldDelimiter_.equals("\0")) return new String("0"); What happens if fieldDelimiter is '\0' and lineDelimiter is '\0'? -- To view, visit http://gerrit.cloudera.org:8080/3266 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id67634282ecf0161a3aa7a3d7f8711b49828668e Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Feng Guangyuan <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-HasComments: Yes
